/juju

Minor changes/fixes to jujuclienttesting #4417

Merged
merged 1 commit into from Feb 15, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@axw @anastasiamac @jujubot
@axw
Member

axw commented Feb 15, 2016

  • Rename NewMemControllerStore to NewMemStore
  • Rename inMemory to MemStore (exported)
  • Export fields of MemStore to enable unit tests
    to initialise test stores succinctly
  • Change type of Models and Accounts fields of
    MemStore to store pointer-to-struct for models
    and accounts; we weren't persisting updates.

(Review request: http://reviews.vapour.ws/r/3857/)
@axw
Minor changes/fixes to jujuclienttesting 
- Rename NewMemControllerStore to NewMemStore
- Rename inMemory to MemStore (exported)
- Export fields of MemStore to enable unit tests
  to initialise test stores succinctly
- Change type of Models and Accounts fields of
  MemStore to store pointer-to-struct for models
  and accounts; we weren't persisting updates.
5686c67
cmd/jujud/bootstrap_test.go
@@ -58,8 +57,6 @@ import (
"github.com/juju/juju/version"
)
-var _ = configstore.Default
@anastasiamac

anastasiamac Feb 15, 2016

Member

Great to see this happening \o/

@anastasiamac
Member

anastasiamac commented Feb 15, 2016

LGTM
@axw
Member

axw commented Feb 15, 2016

$$merge$$
@jujubot
Contributor

jujubot commented Feb 15, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju
@jujubot
Contributor

jujubot commented Feb 15, 2016

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/6388
@axw
Member

axw commented Feb 15, 2016

$$merge$$
@jujubot
Contributor

jujubot commented Feb 15, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju
@jujubot
Contributor

jujubot commented Feb 15, 2016

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/6392
@axw
Member

axw commented Feb 15, 2016

$$merge$$
@jujubot
Contributor

jujubot commented Feb 15, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

jujubot added a commit that referenced this pull request Feb 15, 2016

@jujubot
Merge pull request #4417 from axw/cloud-credentials-jujuclienttesting… 
…-fix

Minor changes/fixes to jujuclienttesting

- Rename NewMemControllerStore to NewMemStore
- Rename inMemory to MemStore (exported)
- Export fields of MemStore to enable unit tests
  to initialise test stores succinctly
- Change type of Models and Accounts fields of
  MemStore to store pointer-to-struct for models
  and accounts; we weren't persisting updates.

(Review request: http://reviews.vapour.ws/r/3857/)
aa080f7

@jujubot jujubot merged commit aa080f7 into juju:cloud-credentials Feb 15, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment