Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
cmd/juju/backups: fix issue 1546826 #4460
Conversation
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Does not match ['fixes-1538241'] |
|
$$JFDI$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
added a commit
that referenced
this pull request
Feb 18, 2016
jujubot
merged commit 1c33736
into
juju:master
Feb 18, 2016
davecheney
deleted the
davecheney:fixedbugs/1546826
branch
Feb 18, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
davecheney commentedFeb 18, 2016
Fixes LP # 1546826
Remove the duplicate configuration of the logger in the backups
subcommand.
There is no test because of the way that the logging configuration
passed to the test runner interacts with logger -- in debug mode the
warning logger is not redefined, but in real use it failed.
This has been manually tested.
We should have an integration test asserting that backup and restore
work as specified.
(Review request: http://reviews.vapour.ws/r/3895/)