/juju

cloudconfig/sshinit: base64 encode initial script #4515

Merged
merged 1 commit into from Feb 24, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@axw @wallyworld @jujubot
@axw
Member

axw commented Feb 24, 2016

Yet another variation on the cloud-config sshinit
script dance. The go.crypto-based ssh client doesn't
like whitespace in the command, so we base64-encode
it and decode on the remote side.

Live-tested with both openssh- and go.crypto-based
clients.

(Review request: http://reviews.vapour.ws/r/3950/)
@axw
cloudconfig/sshinit: base64 encode initial script 
Yet another variation on the cloud-config sshinit
script dance. The go.crypto-based ssh client doesn't
like whitespace in the command, so we base64-encode
it and decode on the remote side.

Live-tested with both openssh- and go.crypto-based
clients.
758fd5b
@wallyworld
Owner

wallyworld commented Feb 24, 2016

LGTM
@axw
Member

axw commented Feb 24, 2016

$$fixes-1548799$$
@jujubot
Contributor

jujubot commented Feb 24, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

jujubot added a commit that referenced this pull request Feb 24, 2016

@jujubot
Merge pull request #4515 from axw/lp1548799-ssh-windows 
cloudconfig/sshinit: base64 encode initial script

Yet another variation on the cloud-config sshinit
script dance. The go.crypto-based ssh client doesn't
like whitespace in the command, so we base64-encode
it and decode on the remote side.

Live-tested with both openssh- and go.crypto-based
clients.

(Review request: http://reviews.vapour.ws/r/3950/)
896c4d0

@jujubot jujubot merged commit 896c4d0 into juju:master Feb 24, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment