/juju

rpc: remove Conn.Go method #4553

Merged
merged 1 commit into from Feb 29, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@davecheney @jujubot
@davecheney
Contributor

davecheney commented Feb 28, 2016

Conn.Go was never called directly, but was exported in the package's
API. As go is a reserved word, this probably explains the method's
public name. Because the method was public, a lot of preconditions, some
panicing had to be set to ensure the method was not called incorrectly.

Remove all of this and collapse Go into its single caller, reducing
the API surface, and ensuring it is always called correctly.

(Review request: http://reviews.vapour.ws/r/3992/)
@davecheney
rpc: remove Conn.Go method 
Conn.Go was never called directly, but was exported in the package's
API. As `go` is a reserved word, this probably explains the method's
public name. Because the method was public, a lot of preconditions, some
panicing had to be set to ensure the method was not called incorrectly.

Remove all of this and collapse `Go` into its single caller, reducing
the API surface, and ensuring it is always called correctly.
3d0a910
@davecheney
Contributor

davecheney commented Feb 29, 2016

$$merge$$
@jujubot
Contributor

jujubot commented Feb 29, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

jujubot added a commit that referenced this pull request Feb 29, 2016

@jujubot
Merge pull request #4553 from davecheney/rpc-cleanup 
rpc: remove Conn.Go method

Conn.Go was never called directly, but was exported in the package's
API. As `go` is a reserved word, this probably explains the method's
public name. Because the method was public, a lot of preconditions, some
panicing had to be set to ensure the method was not called incorrectly.

Remove all of this and collapse `Go` into its single caller, reducing
the API surface, and ensuring it is always called correctly.

(Review request: http://reviews.vapour.ws/r/3992/)
a70da22

@jujubot jujubot merged commit a70da22 into juju:master Feb 29, 2016

@davecheney davecheney deleted the davecheney:rpc-cleanup branch Feb 29, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment