Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
state: unexport UpgradeInProgressError #4611
Conversation
|
$$JFDI$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Tests failed |
|
$$JFDI$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
added a commit
that referenced
this pull request
Mar 4, 2016
jujubot
merged commit 9cc7cb8
into
juju:master
Mar 4, 2016
davecheney
deleted the
davecheney:state-unexport-upgradeinprogress
branch
Mar 4, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
davecheney commentedMar 3, 2016
There are too many ways for juju's API server to tell the client that it
is in upgrade state. Some come from state itself, others come from the
API server interpreting other errors from other sources.
This CL is part of a pair of changes that reduce the number of ways the
API server can say it is in upgrade state. Specifically other packages
can only inspect the error they get from state with the supplied helper
method, they cannot inspect it directly.
This CL is less than ideal is state depends on apiserver/params for the
CodeUpgradeInProgress constant. But this source dependency existed
before hand, so it's not the end of the world.
(Review request: http://reviews.vapour.ws/r/4051/)