resource/api/server: move UnitResourceHandler to public api/server package #4688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
added a commit
that referenced
this pull request
Mar 11, 2016
resource/api/server: move UnitResourceHandler to public api/server package The resources' API had two http handlers, one for services one for units, implemented in two different ways one living inside a _private_ (whatever that means) package. This meant the apiserver had a dependency on apiserver/common via it's import of resources/api/private/server even though the type it was importing did not have anything to do with this transitive dependency. This change moves both handlers to the public resources/api/server package, renaming them to something more descriptive. (Review request: http://reviews.vapour.ws/r/4127/)
ericsnowcurrently
added a commit
to ericsnowcurrently/juju
that referenced
this pull request
Mar 17, 2016
ericsnowcurrently
added a commit
to ericsnowcurrently/juju
that referenced
this pull request
Mar 17, 2016
ericsnowcurrently
added a commit
to ericsnowcurrently/juju
that referenced
this pull request
Mar 21, 2016
ericsnowcurrently
added a commit
to ericsnowcurrently/juju
that referenced
this pull request
Mar 29, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The resources' API had two http handlers, one for services one for units, implemented in two different ways one living inside a private (whatever that means) package. This meant the apiserver had a dependency on apiserver/common via it's import of resources/api/private/server even though the type it was importing did not have anything to do with this transitive dependency.
This change moves both handlers to the public resources/api/server package, renaming them to something more descriptive.
(Review request: http://reviews.vapour.ws/r/4127/)