cmd/jujud/reboot: fix LP 1556630 #4706

Merged

jujubot merged 1 commit into juju:master from davecheney:fixedbugs/1556630

Mar 14, 2016

Contributor

davecheney commented Mar 13, 2016

Fixes LP 1556630

The code was skipping a lot of error conditions which the test code was
relying on to exit the test cleanly.

Also:

reduce the failure timeouts for all tests below the 10m go test dead
man switch
tidy up error handling in general.

This reduced the run time on some of the tests from 3 and 5 seconds to
200ms each.

(Review request: http://reviews.vapour.ws/r/4144/)


      cmd/jujud/reboot: fix LP 1556630

Fixes LP 1556630

The code was skipping a lot of error conditions which the test code was
relying on to exit the test cleanly.

Also:

- reduce the failure timeouts for all tests below the 10m go test dead
  man switch
- tidy up error handling in general.

This reduced the run time on some of the tests from 3 and 5 seconds to
200ms each.

2b239c7

Contributor

davecheney commented Mar 14, 2016

$$JFDI$$

Contributor

jujubot commented Mar 14, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

jujubot added a commit that referenced this pull request Mar 14, 2016


      Merge pull request #4706 from davecheney/fixedbugs/1556630

cmd/jujud/reboot: fix LP 1556630

Fixes LP 1556630

The code was skipping a lot of error conditions which the test code was
relying on to exit the test cleanly.

Also:

- reduce the failure timeouts for all tests below the 10m go test dead
  man switch
- tidy up error handling in general.

This reduced the run time on some of the tests from 3 and 5 seconds to
200ms each.

(Review request: http://reviews.vapour.ws/r/4144/)

jujubot merged commit `2322530` into juju:master Mar 14, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can't perform that action at this time.