container/lxc: hard code loop device manager #4708

Merged
merged 1 commit into from Mar 14, 2016

Conversation

Projects
None yet
2 participants
Contributor

davecheney commented Mar 14, 2016

lxx.NewContainerManager requires a loop device manager. This parameter
is not documented, and there is no check to ensure that it is not nil.
There is only one caller of this method, inside container/factory which
always passes a valid value. This parameter tf. is only used for testing.

This change hard codes the parameter unconditionally passed in via the
the container factory and adds a new test scoped method to alter the
loopback manager for testing.

(Review request: http://reviews.vapour.ws/r/4146/)

container/lxc: hard code loop device manager
lxx.NewContainerManager requires a loop device manager. This parameter
is not documented, and there is no check to ensure that it is not nil.
There is only one caller of this method, inside container/factory which
always passes a valid value. This parameter tf. is only used for testing.

This change hard codes the parameter unconditionally passed in via the
the container factory and adds a new test scoped method to alter the
loopback manager for testing.
Contributor

davecheney commented Mar 14, 2016

$$JFDI_$$

Contributor

jujubot commented Mar 14, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

Contributor

jujubot commented Mar 14, 2016

Build failed: Does not match ['fixes-1556630']
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/6801

Contributor

davecheney commented Mar 14, 2016

$$JFDI$$

Contributor

jujubot commented Mar 14, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

jujubot added a commit that referenced this pull request Mar 14, 2016

Merge pull request #4708 from davecheney/container-lxc-tidy
container/lxc: hard code loop device manager

lxx.NewContainerManager requires a loop device manager. This parameter
is not documented, and there is no check to ensure that it is not nil.
There is only one caller of this method, inside container/factory which
always passes a valid value. This parameter tf. is only used for testing.

This change hard codes the parameter unconditionally passed in via the
the container factory and adds a new test scoped method to alter the
loopback manager for testing.

(Review request: http://reviews.vapour.ws/r/4146/)

@jujubot jujubot merged commit ff4b62d into juju:master Mar 14, 2016

@davecheney davecheney deleted the davecheney:container-lxc-tidy branch Mar 14, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment