Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
container/lxc: hard code loop device manager #4708
Conversation
|
$$JFDI_$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Does not match ['fixes-1556630'] |
|
$$JFDI$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
added a commit
that referenced
this pull request
Mar 14, 2016
jujubot
merged commit ff4b62d
into
juju:master
Mar 14, 2016
davecheney
deleted the
davecheney:container-lxc-tidy
branch
Mar 14, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
davecheney commentedMar 14, 2016
lxx.NewContainerManager requires a loop device manager. This parameter
is not documented, and there is no check to ensure that it is not nil.
There is only one caller of this method, inside container/factory which
always passes a valid value. This parameter tf. is only used for testing.
This change hard codes the parameter unconditionally passed in via the
the container factory and adds a new test scoped method to alter the
loopback manager for testing.
(Review request: http://reviews.vapour.ws/r/4146/)