cmd/juju/agent: Hard code loop manager #4709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Tests failed |
cmd/jujud/agent.MachineAgentFactoryFn only had one caller, who's argument for the loop manager was hard coded. Push this down to the jujud/agent method and add a variant of this function in test scope that supplies a noop mock loop manager.
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
added a commit
that referenced
this pull request
Mar 15, 2016
cmd/juju/agent: Hard code loop manager cmd/jujud/agent.MachineAgentFactoryFn only had one caller, who's argument for the loop manager was hard coded. Push this down to the jujud/agent method and add a variant of this function in test scope that supplies a noop mock loop manager. (Review request: http://reviews.vapour.ws/r/4147/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cmd/jujud/agent.MachineAgentFactoryFn only had one caller, who's
argument for the loop manager was hard coded. Push this down to the
jujud/agent method and add a variant of this function in test scope that
supplies a noop mock loop manager.
(Review request: http://reviews.vapour.ws/r/4147/)