Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
cmd/juju/agent: Hard code loop manager #4709
Conversation
|
$$JFDI$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Tests failed |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
added a commit
that referenced
this pull request
Mar 15, 2016
jujubot
merged commit 78f026b
into
juju:master
Mar 15, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
davecheney commentedMar 14, 2016
cmd/jujud/agent.MachineAgentFactoryFn only had one caller, who's
argument for the loop manager was hard coded. Push this down to the
jujud/agent method and add a variant of this function in test scope that
supplies a noop mock loop manager.
(Review request: http://reviews.vapour.ws/r/4147/)