/juju

core/description: Work around go-yaml limitation under Go 1.6 #4766

Merged
merged 1 commit into from Mar 17, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@mjs @jujubot
@mjs
Contributor

mjs commented Mar 17, 2016

Under Go 1.6, go-yaml panics when it encounters private embedded
types. This is fine in older Go versions and is even fine on Go 1.6
with encoding/json's serialization. go-yaml needs changing and I have
some idea of the changes required but I don't have the time to make
the changes nor them merged upstream. The YAML format produced is
unaffected by this change.

For now, various private embedded types have been made public. This
can be reversed at some point in the future.

This issue is a non-obvious side-effect of
https://golang.org/doc/go1.6#reflect.

(Review request: http://reviews.vapour.ws/r/4206/)
@mjs
core/description: Work around go-yaml limitation under Go 1.6 
Under Go 1.6, go-yaml panics when it encounters private embedded
types. This is fine in older Go versions and is even fine on Go 1.6
with encoding/json's serialization. go-yaml needs changing and I have
some idea of the changes required but I don't have the time to make
the changes nor them merged upstream. The YAML format produced is
unaffected by this change.

For now, various private embedded types have been made public. This
can be reversed at some point in the future.

This issue is a non-obvious side-effect of
https://golang.org/doc/go1.6#reflect.
318c85f
@mjs
Contributor

mjs commented Mar 17, 2016

$$merge$$
@jujubot
Contributor

jujubot commented Mar 17, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

jujubot added a commit that referenced this pull request Mar 17, 2016

@jujubot
Merge pull request #4766 from mjs/core-decription-go16-workaround 
core/description: Work around go-yaml limitation under Go 1.6

Under Go 1.6, go-yaml panics when it encounters private embedded
types. This is fine in older Go versions and is even fine on Go 1.6
with encoding/json's serialization. go-yaml needs changing and I have
some idea of the changes required but I don't have the time to make
the changes nor them merged upstream. The YAML format produced is
unaffected by this change.

For now, various private embedded types have been made public. This
can be reversed at some point in the future.

This issue is a non-obvious side-effect of
https://golang.org/doc/go1.6#reflect.

(Review request: http://reviews.vapour.ws/r/4206/)
66b624d

@jujubot jujubot merged commit 66b624d into juju:model-migration Mar 17, 2016

@mjs mjs deleted the mjs:core-decription-go16-workaround branch Oct 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment