Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
provider/{lxd,gce,vsphere} fix ControllerInstances #4819
Conversation
wallyworld
reviewed
Mar 21, 2016
| -func EnvFullName(env environs.Environ) string { | ||
| - modelUUID := env.Config().UUID() | ||
| +// ModelFullName returns a string based on the provided model | ||
| +// UUID that is suitable for identifying the env on a provider. |
axw
Mar 21, 2016
Member
Ehh, actually, I think it is an environ and not a model. It's the manifestation of a model. I should have left the function name alone.
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
added a commit
that referenced
this pull request
Mar 21, 2016
jujubot
merged commit 380e1f3
into
juju:admin-controller-model
Mar 21, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
axw commentedMar 21, 2016
In ControllerInstances, use controller-uuid rather than
uuid to filter machines. Controllers are always created
with uuid==controller-uuid, but ControllerInstances may
be called on an Environ with uuid!=controller-uuid.
(Review request: http://reviews.vapour.ws/r/4261/)