/juju

provider/gce: remove getSnapshot #4931

Merged
merged 1 commit into from Mar 31, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@davecheney @jujubot
@davecheney
Contributor

davecheney commented Mar 31, 2016

Updates LP 1563628

getSnapshot was being used incorrectly with the expectation that it was
creating an immutable copy of the environment at that point in time.

(Review request: http://reviews.vapour.ws/r/4367/)
@davecheney
Contributor

davecheney commented Mar 31, 2016

$$merge$$
@jujubot
Contributor

jujubot commented Mar 31, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju
@jujubot
Contributor

jujubot commented Mar 31, 2016

Build failed: Generating tarball failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/7111
@davecheney
provider/gce: remove getSnapshot 
Updates LP 1563628

getSnapshot was being used incorrectly with the expectation that it was
creating an immutable copy of the environment at that point in time.
637f0c3
@davecheney
Contributor

davecheney commented Mar 31, 2016

$$merge$$
@jujubot
Contributor

jujubot commented Mar 31, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju
@jujubot
Contributor

jujubot commented Mar 31, 2016

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/7114
@davecheney
Contributor

davecheney commented Mar 31, 2016

$$merge$$
@jujubot
Contributor

jujubot commented Mar 31, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

davecheney added a commit to davecheney/juju that referenced this pull request Mar 31, 2016

@davecheney
worker/metrics/sender: fix mutex copy bug in test 
Fixes 1563628

Fixed accidental copy of a mutex in test.

Fixes LP 1563628 when #4938, #4937 and #4931 are comitted.
9b0810d

davecheney added a commit to davecheney/juju that referenced this pull request Mar 31, 2016

@davecheney
worker/metrics/sender: fix mutex copy bug in test 
Fixes 1563628

Fixed accidental copy of a mutex in test.

Fixes LP 1563628 when #4938, #4937 and #4931 are comitted.
b6d7ca8

@davecheney davecheney referenced this pull request Mar 31, 2016

Merged

worker/metrics/sender: fix mutex copy bug in test #4939

@jujubot
Contributor

jujubot commented Mar 31, 2016

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/7117
@davecheney
Contributor

davecheney commented Mar 31, 2016

$$ffs$$
@jujubot
Contributor

jujubot commented Mar 31, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju
@jujubot
Contributor

jujubot commented Mar 31, 2016

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/7119
@davecheney
Contributor

davecheney commented Mar 31, 2016

$$merge$$
@jujubot
Contributor

jujubot commented Mar 31, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju
@jujubot
Contributor

jujubot commented Mar 31, 2016

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/7129
@davecheney
Contributor

davecheney commented Mar 31, 2016

$$ffs$$
@jujubot
Contributor

jujubot commented Mar 31, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

jujubot added a commit that referenced this pull request Mar 31, 2016

@jujubot
Merge pull request #4939 from davecheney/b 
worker/metrics/sender: fix mutex copy bug in test

Fixes 1563628

Fixed accidental copy of a mutex in test.

Fixes LP 1563628 when #4938, #4937 and #4931 are comitted.

(Review request: http://reviews.vapour.ws/r/4376/)
41ba273

@jujubot jujubot merged commit 67c8fdb into juju:master Mar 31, 2016

@davecheney davecheney deleted the davecheney:fixedbugs/1563628 branch Mar 31, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment