Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider/gce: remove getSnapshot #4931

Merged
merged 1 commit into from Mar 31, 2016
Merged

provider/gce: remove getSnapshot #4931

merged 1 commit into from Mar 31, 2016

Conversation

davecheney
Copy link
Contributor

Updates LP 1563628

getSnapshot was being used incorrectly with the expectation that it was
creating an immutable copy of the environment at that point in time.

(Review request: http://reviews.vapour.ws/r/4367/)

@davecheney
Copy link
Contributor Author

$$merge$$

@jujubot
Copy link
Collaborator

jujubot commented Mar 31, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot
Copy link
Collaborator

jujubot commented Mar 31, 2016

Build failed: Generating tarball failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/7111

@davecheney
provider/gce: remove getSnapshot
637f0c3 
Updates LP 1563628

getSnapshot was being used incorrectly with the expectation that it was
creating an immutable copy of the environment at that point in time.
@davecheney
Copy link
Contributor Author

$$merge$$

@jujubot
Copy link
Collaborator

jujubot commented Mar 31, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot
Copy link
Collaborator

jujubot commented Mar 31, 2016

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/7114

@davecheney
Copy link
Contributor Author

$$merge$$

@jujubot
Copy link
Collaborator

jujubot commented Mar 31, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@davecheney davecheney mentioned this pull request Mar 31, 2016
Merged
@jujubot
Copy link
Collaborator

jujubot commented Mar 31, 2016

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/7117

@davecheney
Copy link
Contributor Author

$$ffs$$

@jujubot
Copy link
Collaborator

jujubot commented Mar 31, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot
Copy link
Collaborator

jujubot commented Mar 31, 2016

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/7119

@davecheney
Copy link
Contributor Author

$$merge$$

@jujubot
Copy link
Collaborator

jujubot commented Mar 31, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot
Copy link
Collaborator

jujubot commented Mar 31, 2016

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/7129

@davecheney
Copy link
Contributor Author

$$ffs$$

@jujubot
Copy link
Collaborator

jujubot commented Mar 31, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

jujubot added a commit that referenced this pull request Mar 31, 2016
@jujubot
Merge pull request #4939 from davecheney/b
41ba273 
worker/metrics/sender: fix mutex copy bug in test

Fixes 1563628

Fixed accidental copy of a mutex in test.

Fixes LP 1563628 when #4938, #4937 and #4931 are comitted.

(Review request: http://reviews.vapour.ws/r/4376/)
@jujubot jujubot merged commit 67c8fdb into juju:master Mar 31, 2016
@davecheney davecheney deleted the fixedbugs/1563628 branch March 31, 2016 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@davecheney @jujubot