lxd provider: better errors when bootstrap failed

[tych0]

When LXD isn't installed:

$ juju bootstrap bob lxd
ERROR invalid config: can't connect to the local LXD server: LXD socket not found; is LXD installed & running?

Please install LXD by running:
$ sudo apt-get install lxd
and then configure it with:
$ newgrp lxd
$ lxd init

When the user doesn't have permissions:

$ juju bootstrap bob lxd
ERROR invalid config: can't connect to the local LXD server: Permisson denied, are you in the lxd group?

Please configure LXD by running:
$ newgrp lxd
$ lxd init

Signed-off-by: Tycho Andersen tycho.andersen@canonical.com

(Review request: http://reviews.vapour.ws/r/4424/)

[jameinel]

Shouldn't there be a test for each of the 4 cases? (EACCES, ENOENT, ECONNREFUSED, and unknown error?

[jameinel]

The change looks very nice. Just want a couple tests to make sure we preserve the functionality.

Originally I thought we should install lxd, but I realize that requires sudo so we should probably ask the user to do it.

[tych0]

On Tue, Apr 05, 2016 at 07:11:39AM -0700, John Arbash Meinel wrote:

The change looks very nice. Just want a couple tests to make sure we preserve the functionality.

Originally I thought we should install lxd, but I realize that requires sudo so we should probably ask the user to do it.

Well, and we want the user to configure their storage backend too
(i.e. hopefully use ZFS). Anyway, I'll add the test shortly.

---

You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#4984 (comment)

[tych0]

Ok, I've added the tests. We needed one small patch to actually be able to test this code path, but other than that it turned out to be pretty simple.

[tych0]

Just a note that I rebased everything and added one more patch on top to warn if lxdbr0 is configured incorrectly (with a test).

[jameinel]

$$merge$$

[jujubot]

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju