/juju

provider/dummy: remove call to dummy.Reset in init() #5005

Merged
merged 3 commits into from Apr 6, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@davecheney @jujubot
@davecheney
Contributor

davecheney commented Apr 6, 2016

Remove the call to dummy.Reset in the package's init() function. With
this call removed, we can change the signature of Reset to always take a
gc.C.

Make dummy.Reset take a *gc.C and use that rather than returning an
error (which is frequently ignored).

This also makes the signature of dummy.Reset compatible with
CleanupSuite.AddCleanup.

(Review request: http://reviews.vapour.ws/r/4447/)

davecheney added some commits Apr 6, 2016

@davecheney
provider/dummy: remove call to dummy.Reset in init() 
Remove the call to dummy.Reset in the package's init() function. With
this call removed, we can change the signature of Reset to always take a
gc.C
b0e242a
@davecheney
environs/dummy: always pass *gc.C to Reset 
Make dummy.Reset take a *gc.C and use that rather than returning an
error (which is frequently ignored).

This also makes the signature of dummy.Reset compatbile with
CleanupSuite.AddCleanup.
9f0a145
@davecheney
responding to review feedback
d24bca7
@davecheney
Contributor

davecheney commented Apr 6, 2016

$$merge$$
@jujubot
Contributor

jujubot commented Apr 6, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit e4019e1 into juju:master Apr 6, 2016

@davecheney davecheney deleted the davecheney:dummy-cleanup branch Apr 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment