provider/azure: honour agent mirrors #5068

Merged
merged 1 commit into from Apr 15, 2016

Conversation

Projects
None yet
2 participants
Member

axw commented Apr 11, 2016

We stopped implementing HasRegion when we moved over
to the Azure Resource Manager API, because we don't
(yet) have usable image simplestreams metadata. This
interface is also required to support agent mirrors,
though.

We introduce a new interface, HasAgentMirror, which may
be implemented instead of HasRegion; it will only be
used when looking up agent simplestreams metadata.
This is a temporary change, which we will replace with
an implementation of HasRegion for Azure when the image
metadata is available.

Fixes https://bugs.launchpad.net/juju-core/+bug/1551779

(Review request: http://reviews.vapour.ws/r/4511/)

Member

axw commented Apr 15, 2016

$$merge$$

Contributor

jujubot commented Apr 15, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

Contributor

jujubot commented Apr 15, 2016

Build failed: Does not match ['fixes-1453805', 'fixes-1568943']
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/7420

provider/azure: honour agent mirrors
We stopped implementing HasRegion when we moved over
to the Azure Resource Manager API, because we don't
(yet) have usable image simplestreams metadata. This
interface is also required to support agent mirrors,
though.

We introduce a new interface, HasAgentMirror, which may
be implemented instead of HasRegion; it will only be
used when looking up agent simplestreams metadata.
This is a temporary change, which we will replace with
an implementation of HasRegion for Azure when the image
metadata is available.

Fixes https://bugs.launchpad.net/juju-core/+bug/1551779
Member

axw commented Apr 15, 2016

$$merge$$

Contributor

jujubot commented Apr 15, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit 71bc9e5 into juju:master Apr 15, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment