/juju

Use the default network config when no juju-specific config is provided #5136

Closed
wants to merge 1 commit into
from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@tych0
@tych0
Contributor

tych0 commented Apr 13, 2016

73a85aa creates network profiles based on network configuration provided
to the container type when network spaces are present (e.g. in maas, etc.).
However, in some cases (notably, AWS, GCE), there is no network
configuration provided to the container type code, and thus the profile
gets created with no network devices.

Instead, let's fall back to the default network configuration in LXD when
nothing is explicitly provided by juju.

Signed-off-by: Tycho Andersen tycho.andersen@canonical.com

(Review request: http://reviews.vapour.ws/r/4575/)
Use the default network config when no juju-specific config is provided 
73a85aa creates network profiles based on network configuration provided
to the container type when network spaces are present (e.g. in maas, etc.).
However, in some cases (notably, AWS, GCE), there is no network
configuration provided to the container type code, and thus the profile
gets created with no network devices.

Instead, let's fall back to the default network configuration in LXD when
nothing is explicitly provided by juju.

Signed-off-by: Tycho Andersen <tycho.andersen@canonical.com>
b25d47b

frobware pushed a commit to frobware/juju that referenced this pull request Apr 15, 2016

container/lxd: fallback to "default" LXD profile 
This was work originally started by Tycho in:

  juju#5136

but updated to consider the case where we have a default bridge from the
provider and we should use that before falling back to LXD's "default"
profile.

Original - PR: juju#5136

73a85aa creates network profiles based on network configuration
provided to the container type when network spaces are present (e.g. in
maas, etc.). However, in some cases (notably, GCE), there is no network
configuration provided to the container type code, and thus the profile
gets created with no network devices.

Instead, let's fall back to the default network configuration in LXD
when nothing is explicitly provided by juju.
630ae42

@frobware frobware referenced this pull request Apr 15, 2016

Merged

container/lxd: fallback to "default" LXD profile #5176

@tych0
Contributor

tych0 commented Apr 15, 2016

Closing in favor of #5176

@tych0 tych0 closed this Apr 15, 2016

jujubot added a commit that referenced this pull request Apr 18, 2016

@jujubot
Merge pull request #5176 from frobware/fallback-to-lxd-default-profile 
container/lxd: fallback to "default" LXD profile

This was work originally started by Tycho in:

  #5136

but updated to consider the case where we have a default bridge from the
provider and we should use that before falling back to LXD's "default"
profile.

Original - PR: #5136

73a85aa creates network profiles based on network configuration
provided to the container type when network spaces are present (e.g. in
maas, etc.). However, in some cases (notably, GCE), there is no network
configuration provided to the container type code, and thus the profile
gets created with no network devices.

Instead, let's fall back to the default network configuration in LXD
when nothing is explicitly provided by juju.

(Review request: http://reviews.vapour.ws/r/4609/)
32a4a55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment