Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Disable the SSH client tests on Windows #5449
Conversation
|
$$fixes-1584815$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Generating tarball failed |
jujubot
merged commit 8e79006
into
juju:master
May 27, 2016
mjs
deleted the
mjs:1584815-no-windows-opensshtests
branch
May 27, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
mjs commentedMay 24, 2016
•
Edited 1 time
-
ericsnowcurrently
May 24, 2016
The tests haven't worked on Windows since PR #5352 landed and making them work there now has proved to be quite difficult, either involving the use of some terrible, unmaintable batch scripting or some major changes to the tests. Given that the tests only exercise the openssh based connections (as opposed to gocrypto) and that it's unlikely that openssh client software will actually be available on a windows client machine, we don't lose much by not running these test on Windows.
Fixes LP #1584815.
(Review request: http://reviews.vapour.ws/r/4888/)