Disable the SSH client tests on Windows #5449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests haven't worked on Windows since PR juju#5352 landed and making them work there now has proved to be quite difficult, either involving the use of some terrible, unmaintable batch scripting or some major changes to the tests. Given that the tests only exercise the openssh based connections (as opposed to gocrypto) and that it's unlikely that openssh client software will actually be available on a windows client machine, we don't lose much by not running these test on Windows. Fixes LP #1584815.
mjs
force-pushed
the
1584815-no-windows-opensshtests
branch
from
7ae1847
to
fc8ab89
Compare
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Generating tarball failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests haven't worked on Windows since PR #5352 landed and making them work there now has proved to be quite difficult, either involving the use of some terrible, unmaintable batch scripting or some major changes to the tests. Given that the tests only exercise the openssh based connections (as opposed to gocrypto) and that it's unlikely that openssh client software will actually be available on a windows client machine, we don't lose much by not running these test on Windows.
Fixes LP #1584815.
(Review request: http://reviews.vapour.ws/r/4888/)