Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
state: re-enable tests under race detector #5452
Conversation
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Tests failed |
|
$$oh-the-irony$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
merged commit 47afe90
into
juju:master
May 25, 2016
davecheney
deleted the
davecheney:fixedbugs/1519095
branch
May 25, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
davecheney commentedMay 25, 2016
•
Edited 1 time
-
ericsnowcurrently
May 25, 2016
Fixes LP 1519095
The good news, there are no data races in state currently.
The bad news, the tests take about 1.5x the time to run. On my machine
it is the difference between 15 minutes and 25 minutes to run the -race
tests for this package. Those times will be higher if other tests are
run in parallel (which is the default mode when testing multiple
packages).
(Review request: http://reviews.vapour.ws/r/4893/)