Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve bug in userdata, unsupported format. #5457

Merged
merged 3 commits into from May 26, 2016
Merged

Resolve bug in userdata, unsupported format. #5457

merged 3 commits into from May 26, 2016

Conversation

hoenirvili
Copy link
Contributor

@hoenirvili hoenirvili commented May 25, 2016

This is happening when the UserDataScript string is formatted
it adds in the process two new "\n\n". In order to prevent this we must
add the powershell header separate and cocat it. Bug:
(https://bugs.launchpad.net/juju-core/+bug/1585430).

(Review request: http://reviews.vapour.ws/r/4900/)

This is happening when the UserDataScript string is formatted
it adds in the process two new "\n\n". In order to prevent this we must
add the powershell header separate and cocat it. Bug:
(https://bugs.launchpad.net/juju-core/+bug/1585430).
@kat-co
Copy link
Contributor

kat-co commented May 25, 2016

Please review the review at the link provided in the PR.

@axw
Copy link
Contributor

axw commented May 26, 2016

$$fixes-1585430$$

@jujubot
Copy link
Collaborator

jujubot commented May 26, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot
Copy link
Collaborator

jujubot commented May 26, 2016

Build failed: Does not match ['fixes-1581074', 'fixes-1580418', 'fixes-1577945']
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/7872

@sinzui
Copy link
Contributor

sinzui commented May 26, 2016

$$merge$$ fixes-1585430

@jujubot
Copy link
Collaborator

jujubot commented May 26, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit 9ceef58 into juju:master May 26, 2016
@hoenirvili hoenirvili deleted the deploy-fix branch May 26, 2016 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants