Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Fixes LP#1514874: login failures with valid credentials. #5506
Conversation
axw
reviewed
Jun 1, 2016
| + // we can connect with old password. | ||
| + info.Password = agentConfig.OldPassword() | ||
| + } | ||
| + |
axw
Jun 1, 2016
Member
this feels a bit odd, why not just check for info.Password == "" in openAPIStateUsingInfo?
axw
reviewed
Jun 1, 2016
| if err != nil { | ||
| return nil, err | ||
| } | ||
| - // Reconnect to the API with the new password. | ||
| + // Before we reconnect to the API with the new password, |
anastasiamac
added some commits
Jun 1, 2016
|
$$fixes-1514874$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
merged commit 77ec347
into
juju:1.25
Jun 1, 2016
anastasiamac
deleted the
anastasiamac:too-many-logins
branch
Jun 1, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
anastasiamac commentedJun 1, 2016
•
Edited 1 time
-
ericsnowcurrently
Jun 1, 2016
When we create agent configuration for juju entities, we do not specify password since we want to generate a new one. However, we do have access to the old password sent over wire.
Prior to this PR, we would try to login 3 times:
This PR ensures that we do not try to login with no password \o/
I am still running tests suites but am proposing the actual code change to get early feedback.
(Review request: http://reviews.vapour.ws/r/4951/)