Bootstrap print clouds #5525
Merged
Bootstrap print clouds #5525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| juju bootstrap --config=~/config-rs.yaml mycontroller rackspace | ||
| juju bootstrap --config agent-version=1.25.3 mycontroller aws | ||
| juju bootstrap --config bootstrap-timeout=1200 mycontroller azure | ||
| juju bootstrap |
There was a problem hiding this comment.
maybe add a "# interactive bootstrap" afterwards?
and similar comments for "--clouds" and "--regions aws"?
|
LGTM |
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now support:
bootstrap --clouds
bootstrap --regions
The "local." prefix is also removed from controller names on bootstrap.
This is the first in a series of changes to introduce interactive bootstrap.
Tested using lxd provider. Ran commands such as switch, list-controllers, show-controller etc
(Review request: http://reviews.vapour.ws/r/4972/)