/juju

state/presence: make presence workers implement worker.Worker #5563

Merged
merged 1 commit into from Jun 8, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@davecheney @jujubot
@davecheney
Contributor

davecheney commented Jun 8, 2016 •
Edited 1 time

Updates LP 1590161

Followup to juju/juju#5543 as requested by @fwreade

This change makes presence worker types implement worker.Worker which
allows us to use the worker.Stop(w) helper. This in turn unblocks parts
of juju/juju#5543 which had to be rolled back. See 1590161 for details.

(Review request: http://reviews.vapour.ws/r/5007/)
@davecheney
state/presence: make presence workers implement worker.Worker 
Updates LP 1590161

Followup to juju/juju#5543 as requested by @fwreade

This change makes presence worker types implement worker.Worker which
allows us to use the worker.Stop(w) helper. This in turn unblocks parts
of juju/juju#5543 which had to be rolled back. See 1590161 for details.
787ca77
@davecheney
Contributor

davecheney commented Jun 8, 2016

$$JFDI$$
@jujubot
Contributor

jujubot commented Jun 8, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit a23d99c into juju:master Jun 8, 2016

@davecheney davecheney deleted the davecheney:state-presence-assertstopped branch Jun 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment