Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
worker/firewaller: register machined with firewaller's catacomb #5594
Conversation
|
$$JFDI$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
merged commit 36d4216
into
juju:master
Jun 10, 2016
davecheney
deleted the
davecheney:worker-firewaller-dont-loose-track-of-machiend
branch
Jun 10, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
davecheney commentedJun 10, 2016
•
Edited 1 time
-
ericsnowcurrently
Jun 10, 2016
Updates 1590161
Firewaller.startMachine registers the unitd with the containing
firewaller's catacomb, but the machined which mangers units is not
tracked. This machined will die when any of its component units dies,
but its lifetime is not bound to the containing firewaller's catacomb,
so it can remain alive when the firewaller is considered stopped.
This can lead to panics when pingers for the machine that the machined
is responsible for have not died by the time the test is being torn
down.
(Review request: http://reviews.vapour.ws/r/5038/)