/juju

cmd/juju: Swap out natural sorting implementation #5666

Merged
merged 1 commit into from Jun 21, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@mjs @jujubot @babbageclunk
@mjs
Contributor

mjs commented Jun 20, 2016 •
Edited 1 time

The natural sorting implementation has been extracted to github.com/juju/utils and improved. Now use that and remove the implementation in github.com/juju/juju/cmd/juju/common.

(Review request: http://reviews.vapour.ws/r/5111/)
@mjs
cmd/juju: Swap out natural sorting implementation 
The natural sorting implementation has been extracted to
github.com/juju/utils and improved. Now use that and remove the
implementation in github.com/juju/juju/cmd/juju/common.
176b345
@mjs
Contributor

mjs commented Jun 20, 2016

$$merge$$
@jujubot
Contributor

jujubot commented Jun 20, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit 6cd7f38 into juju:model-migration Jun 21, 2016

@mjs mjs deleted the mjs:swap-natural-sort branch Jun 21, 2016

@babbageclunk
Member

babbageclunk commented Jul 15, 2016

Why was this change made against model-migration rather than master? It's not related to model-migration at all as far as I can tell, and having it here made it very hard to understand why I was seeing weird sorting behaviour when I knew this had been done. It would have been better to JFDI it onto master (despite it being blocked) than have it be theoretically fixed but languishing here waiting for the rest of the model-migration work to be finished. Can we cherry-pick it across to master?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment