/juju

state: rewrite AssertChange and AssertNoChange #5678

Merged
merged 2 commits into from Jun 22, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@davecheney @jujubot
@davecheney
Contributor

davecheney commented Jun 21, 2016 •
Edited 1 time

Fixes LP 1588575

Rewrite AssertChange and assertNoChange helpers to (hopefully) be less
flaky. Waiting for a value to arrive, or not arrive, is inherently
flaky.

(Review request: http://reviews.vapour.ws/r/5122/)

davecheney added some commits Jun 21, 2016

@davecheney
state: rewrite AssertChange and AssertNoChange 
Fixes LP 1588575

Rewrite AssertChange and assertNoChange helpers to (hopefully) be less
flaky. Waiting for a value to arrive, or not arrive, is inherently
flaky.
dd2ed6e
@davecheney
responding to review feedback
ca1a949
@davecheney
Contributor

davecheney commented Jun 22, 2016

$$fixes-1588575$$
@jujubot
Contributor

jujubot commented Jun 22, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju
@jujubot
Contributor

jujubot commented Jun 22, 2016

Build failed: Does not match ['fixes-1593299', 'fixes-1594580', 'fixes-1593761', 'fixes-1591290', 'fixes-1581157', 'fixes-1593838', 'fixes-1586890']
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/8224
@davecheney
Contributor

davecheney commented Jun 22, 2016

$$JFDI$$
@jujubot
Contributor

jujubot commented Jun 22, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit c120016 into juju:master Jun 22, 2016

@davecheney davecheney deleted the davecheney:fixedbugs/1588575 branch Jun 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment