/juju

apiserver: add workload version to API #5679

Closed
wants to merge 16 commits into
from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@babbageclunk
@babbageclunk
Member

babbageclunk commented Jun 21, 2016 •
Edited 1 time

Add WorkloadVersion and SetWorkloadVersion to the uniter API, and workload version information in the Status structure.

Unit workload version is reported and it's also aggregated up to the application level. If the units are reporting different versions the most common version is used, with a * to indicate that there is some deviation (which can then be investigated at the unit level).

This builds on PR #5650 which is blocked, so it appears to include all of those changes as well - I'll update the review in RB to show only the changes for this branch.

babbageclunk added some commits Jun 14, 2016

@babbageclunk
Add Unit.WorkloadVersion to state 
First step of propagating workload version from units to juju status.
158096c
@babbageclunk
Move description/service.go to application.go 
And tests as well. (Drive-by)
66441ce
@babbageclunk
Add Unit.WorkloadVersion() to model description
3c7b48d
@babbageclunk
Add Unit.WorkloadVersion to export/import 
Also drive-by changed some test names from Service to Application.
43e5015
@babbageclunk
Store workload version in status 
Rather than storing it as an attribute of the unit doc. We want to avoid
adding new fields to existing documents - each one means that there are
more possible things that could change that would notify all of the
watchers hanging off the document, increasing the likelihood of
unnecessary message storms.
6c41d94
@babbageclunk
Merge remote-tracking branch 'upstream/master' into unit-workload-ver… 
…sion
1d6bbed
@babbageclunk
Merge remote-tracking branch 'upstream/master' into unit-workload-ver… 
…sion
cdc27f6
@babbageclunk
Update description for workload version history 
We may as well carry this across as well, since it's in the model.
5e0aa29
@babbageclunk
Include workload version history in migrated data
fbd9c11
@babbageclunk
Merge remote-tracking branch 'upstream/master' into unit-workload-ver… 
…sion
63a47c9
@babbageclunk
Review change - reformatted a comment
5ef352f
@babbageclunk
Merge remote-tracking branch 'upstream/master' into unit-workload-ver… 
…sion
c6834d0
@babbageclunk
Add get/set workload methods to the uniter API
d53b68e
@babbageclunk
Include unit workload version in status response
0b4cec8
@babbageclunk
Combine unit workload versions to application 
Pick the mode, excluding "" (because it's unset). In the case of a tie
pick the first lexicographically. If there are multiple unit versions,
add a * on the end of the application version.
b3148ae
@babbageclunk
Merge combineUnitVersions into processApplication 
Shorter, less data shuffling and just as clear.
6e294f5

@babbageclunk babbageclunk closed this Jun 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment