/juju

container/lxd: use API capabilities from LXD 2.0.0 only #5769

Merged
merged 1 commit into from Jul 7, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@frobware @jujubot
@frobware
Contributor

frobware commented Jul 7, 2016 •
Edited 1 time

Creating and assigning LXD network devices directly to the container is
currently using a breaking LXD API change - as far as Juju 2.0 packaging
is concerned. We revert the dependency on the more convenient LXD API
and switch to using 'init', then 'add device(s)'.

This change mantains the existing behaviour of adding/applying the
network devices to the container directly, and does not require a
discrete network profile per launched container.

You can see the set of [network] devices the container has via:

$ lxc config show

Fixes LP:#1597342

(Review request: http://reviews.vapour.ws/r/5212/)
container/lxd: use API capabilities from LXD 2.0.0 only 
Creating and assigning LXD network devices directly to the container is
currently using a breaking LXD API change - as far as Juju 2.0 packaging
is concerned. We revert the dependency on the more convenient LXD API
and switch to using 'init', then 'add device(s)'.

This change mantains the existing behaviour of adding/applying the
network devices to the container directly, and does not require a
discrete network profile per launched container.

You can see the set of [network] devices the container has via:

  $ lxc config show <container-name>

Fixes [LP:#1597342](https://bugs.launchpad.net/juju-core/+bug/1597342)
20f2a9e
@frobware
Contributor

frobware commented Jul 7, 2016

$$JFDI$$ $$merge$$ $$fixes-1597342$$
@jujubot
Contributor

jujubot commented Jul 7, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit 456f317 into juju:master Jul 7, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment