/juju

provider/maas: remove MTU option from the bridge options #5791

Merged
merged 1 commit into from Jul 14, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@frobware @jujubot
@frobware
Contributor

frobware commented Jul 13, 2016 •
Edited 1 time

The MTU statement must be on the interface to work and not on the bridge
itself; bridges inherit the lowest MTU of all sub-interfaces. Further to
this, ifupdown seems to bug out and always fails to add the default
route when an MTU is set on the bridge. Leaving the MTU option on the
bridge completely breaks the network on reboot.

This commit also removes:

address
gateway
netmask
dns-nameservers
dns-search
dns-sortlist

from the sub-interfaces, leaving them on the bridge interface only.

Fixes LP:#1584616

(Review request: http://reviews.vapour.ws/r/5234/)
provider/maas: remove MTU option from the bridge options 
The MTU statement must be on the interface to work and not on the bridge
itself; bridges inherit the lowest MTU of all sub-interfaces. Further to
this, ifupdown seems to bug out and always fails to add the default
route when an MTU is set on the bridge. Leaving the MTU option on the
bridge completely breaks the network on reboot.

This commit also removes:

  address
  gateway
  netmask
  dns-nameservers
  dns-search
  dns-sortlist

from the sub-interfaces, leaving them on the bridge interface only.

Fixes [LP:#1584616](https://bugs.launchpad.net/juju-core/+bug/1584616)
d2ec6ef
@frobware
Contributor

frobware commented Jul 14, 2016

$$merge$$ $$fixes-1584616$$
@jujubot
Contributor

jujubot commented Jul 14, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit d836575 into juju:master Jul 14, 2016

@voidspace voidspace referenced this pull request Aug 17, 2016

Merged

provider/maas: remove MTU option from the bridge (backport) #6013

jujubot added a commit that referenced this pull request Aug 19, 2016

@jujubot
Merge pull request #6013 from voidspace/1.25-bridge 
provider/maas: remove MTU option from the bridge (backport)

Backport of PR #5791.

The MTU statement must be on the interface to work and not on the bridge
itself; bridges inherit the lowest MTU of all sub-interfaces. Further to
this, ifupdown seems to bug out and always fails to add the default
route when an MTU is set on the bridge. Leaving the MTU option on the
bridge completely breaks the network on reboot.

This commit also removes:

address
gateway
netmask
dns-nameservers
dns-search
dns-sortlist

from the sub-interfaces, leaving them on the bridge interface only.

(Review request: http://reviews.vapour.ws/r/5460/)
bbda325
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment