/juju

lxd: Properly store the image source (auto-update) #5869

Closed
wants to merge 1 commit into
from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@stgraber @wallyworld @jujubot
@stgraber

stgraber commented Jul 26, 2016

In current code, Juju resolves the image alias prior to copying the
image into the local image store.

This means that the local LXD daemon won't know what the image alias was
and so can't auto-update the image in the future.

Fix this by just passing the alias straight to LXD, but still resolve it
in Juju before so the log messages and errors remain identical.

Signed-off-by: Stéphane Graber stgraber@ubuntu.com
@stgraber
lxd: Properly store the image source (auto-update) 
In current code, Juju resolves the image alias prior to copying the
image into the local image store.

This means that the local LXD daemon won't know what the image alias was
and so can't auto-update the image in the future.

Fix this by just passing the alias straight to LXD, but still resolve it
in Juju before so the log messages and errors remain identical.

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>
a298d55
@stgraber

stgraber commented Jul 26, 2016

As discussed in Leiden.
@wallyworld
Owner

wallyworld commented Aug 15, 2016

$$merge$$
@jujubot
Contributor

jujubot commented Aug 15, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju
@jujubot
Contributor

jujubot commented Aug 15, 2016

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/8755
@wallyworld
Owner

wallyworld commented Aug 15, 2016

This failed unit tests http://juju-ci.vapour.ws:8080/job/github-merge-juju/8755/artifact/artifacts/trusty-out.log

@wallyworld wallyworld referenced this pull request Aug 25, 2016

Merged

Use the correct lxd image alias #6090

@wallyworld
Owner

wallyworld commented Aug 25, 2016

I added the test changes in #6090
So closing this one. Thanks for the fix.

@wallyworld wallyworld closed this Aug 25, 2016

jujubot added a commit that referenced this pull request Aug 25, 2016

@jujubot
Merge pull request #6090 from wallyworld/lxd-image-source 
Use the correct lxd image alias

Originally submitted by Stéphane as #5869 
"In current code, Juju resolves the image alias prior to copying the
image into the local image store.

This means that the local LXD daemon won't know what the image alias was
and so can't auto-update the image in the future.

Fix this by just passing the alias straight to LXD, but still resolve it
in Juju before so the log messages and errors remain identical."

I did the test changes.


(Review request: http://reviews.vapour.ws/r/5529/)
6884ed9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment