Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Local charm revision metadata is once again saved #5906
Conversation
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Does not match ['fixes-1603221'] |
|
$$JFDI$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Tests failed |
|
$$JFDI$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
merged commit 813fef9
into
juju:master
Aug 4, 2016
kat-co
deleted the
kat-co:fix-1605096
branch
Oct 4, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
kat-co commentedAug 1, 2016
•
Edited 1 time
-
ericsnowcurrently
Aug 1, 2016
One of the things the fix for lp:1580418 did is remove obsolete charm documents from mongo. This had the side-effect of resetting a local charm's revision number when the charm was completely removed from the environment. There is another bug where the filesystem cache is not cleared out when a charm is removed, and fixing this bug would also fix this bug, but after discussing with William Reade, it was apparent that the more holistic approach was to bring local charms back into the fold with regards to a charm URL representing a specific revision of a charm archive. Breaking this concept can have many unintended consequences.
Fixes: https://bugs.launchpad.net/juju-core/+bug/1605096
(Review request: http://reviews.vapour.ws/r/5344/)