Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
cmd/jujud/agent: Ensure workers are stable in tests #5908
Conversation
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Does not match ['fixes-1603221'] |
|
$$JFDI$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
merged commit cebf677
into
juju:master
Aug 2, 2016
mjs
deleted the
mjs:1600301-reliable-fail
branch
Aug 2, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
mjs commentedAug 1, 2016
•
Edited 1 time
-
ericsnowcurrently
Aug 1, 2016
EngineMatchFunc has been replaced with NewWorkerMatcher. NewWorkerMatcher uses the same approach as EngineMatchFunc but will only report a match if the required workers have been running for at least 1s. This means that TestHostedModelWorkers - which is known to have problems - now fails reliably (it is still being skipped - fix coming).
All tests which used EngineMatchFunc now use NewWorkerMatcher.
TestMigratingModelWorkers was been reenabled. It doesn't suffer from the same issue as TestHostedModelWorkers, is actually passing reliably and shouldn't have been skipped.
The WaitMatch helper is now used in all places where it can be - reducing a significant amount of test boilerplate.
(Review request: http://reviews.vapour.ws/r/5346/)