/juju

state: fix UpdateCloudCredentials for existing creds #5917

Merged
merged 1 commit into from Aug 5, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@rogpeppe @jujubot
@rogpeppe
Owner

rogpeppe commented Aug 2, 2016 •
Edited 1 time

state: fix UpdateCloudCredentials for existing creds

UpdateCloudCredentials didn't work when there were existing
credentials with the same name.

To test this properly, we required different clouds with different
credentials, so we implement a CreateCloud method too.

Fixes https://bugs.launchpad.net/juju-core/+bug/1608421.

Partially addresses https://bugs.launchpad.net/juju-core/+bug/1608494.

(Review request: http://reviews.vapour.ws/r/5357/)
@rogpeppe
Owner

rogpeppe commented Aug 3, 2016

$$merge$$
@jujubot
Contributor

jujubot commented Aug 3, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju
@jujubot
Contributor

jujubot commented Aug 3, 2016

Build failed: Does not match ['fixes-1603221', 'fixes-1607557']
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/8610
@rogpeppe
state: fix UpdateCloudCredentials for existing creds 
UpdateCloudCredentials didn't work when there were existing
credentials with the same name.

To test this properly, we required different clouds with different
credentials, so we implement a CreateCloud method too.

Fixes https://bugs.launchpad.net/juju-core/+bug/1608421.

Partially addresses https://bugs.launchpad.net/juju-core/+bug/1608494.
cccdbf4
@rogpeppe
Owner

rogpeppe commented Aug 5, 2016

$$merge$$
@jujubot
Contributor

jujubot commented Aug 5, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit cc1955b into juju:master Aug 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment