/juju

api/controller: add failing test for API server termination #5984

Merged
merged 1 commit into from Aug 12, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@rogpeppe @urosj @jujubot
@rogpeppe
Owner

rogpeppe commented Aug 12, 2016 •
Edited 1 time

Currently the API server cannot be terminated if there is an
outstanding Next call on a controller-only connection.

This PR adds a (failing, therefore skipped) test for that,
which will be fixed in a subsequent PR.

As part of doing this, we add support for tests to obtain controller-only
API connections.

(Review request: http://reviews.vapour.ws/r/5424/)
@rogpeppe
api/controller: add failing test for API server termination 
Currently the API server cannot be terminated if there is an
outstanding Next call on a controller-only connection.

This PR adds a (failing, therefore skipped) test for that,
which will be fixed in a subsequent PR.

As part of doing this, we add support for tests to obtain controller-only
API connections.
ed4b6b0
@rogpeppe
Owner

rogpeppe commented Aug 12, 2016

To QA, comment out the Skip call and verify that the test actually times out.
@urosj
Owner

urosj commented Aug 12, 2016

👍

@jujubot jujubot merged commit ed4b6b0 into juju:master Aug 12, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment