/juju

Migrate storage pools #6024

Merged
merged 1 commit into from Aug 19, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@howbazaar @axw @jujubot
@howbazaar
Owner

howbazaar commented Aug 18, 2016 •
Edited 1 time

No CI yet, almost there, just storage constraints to go.

(Review request: http://reviews.vapour.ws/r/5472/)
state/migration_import.go
+ for _, pool := range i.model.StoragePools() {
+ _, err := pm.Create(pool.Name(), storage.ProviderType(pool.Provider()), pool.Attributes())
+ if err != nil {
+ return errors.Annotatef(err, "pool %q", pool.Name())
@axw

axw Aug 19, 2016

Member

"creating pool %q" perhaps?

@howbazaar

howbazaar Aug 19, 2016

Owner

done

@axw
Member

axw commented Aug 19, 2016

LGTM
@howbazaar
Owner

howbazaar commented Aug 19, 2016

$$merge$$
@jujubot
Contributor

jujubot commented Aug 19, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit 6da7576 into juju:master Aug 19, 2016

@howbazaar howbazaar deleted the howbazaar:migrate-storage-pools branch Aug 19, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment