Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
state: isolate/generalise refcounting #6040
Conversation
voidspace
commented
Aug 22, 2016
|
The deploy isn't clean, which probably doesn't matter for this specific branch. There's a problem with kibana: kibana/0 error idle 2 54.196.108.173 80/tcp,9200/tcp hook failed: "rest-relation-changed" for elasticsearch:client |
voidspace
commented
Aug 22, 2016
|
Deployed to AWS. Both kill-controller and destroy-controller (two separate deploys) worked fine. |
|
Thanks Michael. Sorry the instructions weren't clear: the point was indeed to safely tidy up non-clean deploys. |
voidspace
commented
Aug 22, 2016
|
LGTM |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Tests failed |
|
mongo failures; $$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Tests failed |
|
mongo again; /sigh; $$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
fwereade commentedAug 19, 2016
Refcount values are (1) implied by the rest of a model description and
(2) pure implementation details necessitated by mgo/txn. They've been
dropped from description.Application; refcount sanity is now maintained
implicitly during import by the add*Ops-level funcs.
Refcount operations themselves have been extracted to refcounts_ns.go
...and the "settingsrefs" collection has been renamed to "refcounts",
reflecting its broader purpose.
Charm refcounts have been added, but nothing currently holds references
to them.
This is identical to PR5939, except that nsRefcounts.JustRemoveOp now accepts a negative value to indicate "don't assert anything, just kill it". To QA, deploy ~/containers/bundle/elk-stack and wait for all machines to be started; then destroy-controller --destroy-all-models, and check that everything gets cleaned up.