/juju

Use txn-revno to assert that APIHostPorts are unchanged #6055

Merged
merged 1 commit into from Aug 22, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
in progress
Projects
None yet
Milestone
No milestone
3 participants
@voidspace @jujubot @frobware
@voidspace

voidspace commented Aug 22, 2016 •
Edited 1 time

Fixes LP Bug #1613855

https://bugs.launchpad.net/juju-core/+bug/1613855

Instead of asserting that the APIHostPorts are unchanged, which can break under contention, we use txn-reno.

QA
There are existing tests for concurrent changes in SetAPIHostPorts (in state/state_test.go) and these pass.

(Review request: http://reviews.vapour.ws/r/5497/)

@frobware frobware added the in progress label Aug 22, 2016

@voidspace

voidspace commented Aug 22, 2016

$$merge$$
@jujubot
Contributor

jujubot commented Aug 22, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit 58f66e1 into juju:master Aug 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment