Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Make upgrade-gui a controller command. #6181
+251
−183
Conversation
|
Nice changes, thanks. Code LGTM. Haven't QAed; EODing soon; can I hand that off to redir please? |
|
Fabrice QAed that already, thank you all for the reviews! |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
merged commit 98b0424
into
juju:master
Sep 7, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
frankban commentedSep 7, 2016
•
Edited 1 time
-
ericsnowcurrently
Sep 7, 2016
Move the API client methods to the controller client.
Also implement a way to mock controller HTTP calls.
QA:
juju help upgrade-guiand check that a -c (--controller) option is now available;juju upgrade-gui --listand check that it properly returns a list of GUI archives available on simplestreams;juju upgrade-guito check that we already are at the most recent version (i.e. output should be "Juju GUI at version 2.1.10");juju upgrade-gui 2.1.8to switch to an older version;juju guiand check that in this old version the login form was a bit weird (with really large text inputs);juju upgrade-gui no-such: it should output "ERROR invalid GUI release version or local path "no-such"";juju upgrade-gui 0.0.1: it should output "ERROR Juju GUI release version 0.0.1 not found";juju upgrade-gui ~/path/to/jujugui-2.1.11.tar.bz2and check that the upgrade suceeds;juju gui --show-credentials: check that the login form is now rendered properly;(Review request: http://reviews.vapour.ws/r/5619/)