/juju

Improve go vet checks #6198

Merged
merged 2 commits into from Sep 9, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@mjs @jujubot @wallyworld
@mjs
Contributor

mjs commented Sep 8, 2016 •
Edited 1 time

Instead of selectively enabling specific checks, just disable the ones that don't work for Juju. Also, enable checking of a lot more print style functions commonly used within Juju, defining them in a maintainable way.

Fixed two incorrect format strings found by the changes.

(Review request: http://reviews.vapour.ws/r/5634/)

mjs added some commits Sep 8, 2016

@mjs
Improve go vet checks 
Instead of selectively enabling specific checks, just disable the ones
that don't work for Juju.

Also, enable checking of a lot more print style functions commonly used
within Juju, defining them in a maintainable way.
73a610e
@mjs
Fixed incorrect format strings 
These were picked up after improving the go vet command used in
scripts/verify.sh and they're only found under Go 1.7. go vet under 1.6
doesn't seem to do checking for %t.
b896d8d
@mjs
Contributor

mjs commented Sep 8, 2016

$$merge$$
@jujubot
Contributor

jujubot commented Sep 8, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju
@jujubot
Contributor

jujubot commented Sep 9, 2016

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/9152
@mjs
Contributor

mjs commented Sep 9, 2016

$$merge$$
@jujubot
Contributor

jujubot commented Sep 9, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju
@jujubot
Contributor

jujubot commented Sep 9, 2016

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/9153
@mjs
Contributor

mjs commented Sep 9, 2016

$$intermittent-tests$$
@wallyworld
Owner

wallyworld commented Sep 9, 2016

$$merge$$
@jujubot
Contributor

jujubot commented Sep 9, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit 8b59f4e into juju:master Sep 9, 2016

@mjs mjs deleted the mjs:verify-improvements branch Sep 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment