Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Handle run action operation for terminated actions #6231
Conversation
added some commits
Sep 9, 2016
voidspace
commented
Sep 14, 2016
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
merged commit 3ac52be
into
juju:master
Sep 14, 2016
voidspace
deleted the
voidspace:1534103-run-action
branch
Oct 6, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
voidspace commentedSep 13, 2016
•
Edited 1 time
-
ericsnowcurrently
Sep 13, 2016
Fixes Bug #1534103.
Handle operations of kind RunAction where the action has terminated, by marking the action as failed.
To QA:
Bootstrap and deploy a charm with a long running action.
Trigger the action.
Whilst the action is running execute:
juju run --application APPNAME 'sudo shutdown -r now'
Fetch the output of the action. The action should be marked as failed.
There should be no log error lines saying " error: unknown operation kind run-action".
(Review request: http://reviews.vapour.ws/r/5667/)