Fixes lp#1552274 - added json output to list-credentials command. #6274

Merged
merged 3 commits into from Sep 20, 2016

Conversation

Projects
None yet
3 participants
Member

anastasiamac commented Sep 19, 2016

Added presentation layer credentials struct. Added tests for json output.

QA:

  1. Run 'juju credentials --format json"
    [expected] output should have lower-cased representation of credentials with empty properties omitted

axw approved these changes Sep 19, 2016

LGTM with one small change.

cmd/juju/cloud/listcredentials.go
@@ -61,8 +61,35 @@ type listCredentialsCommand struct {
cloudByNameFunc func(string) (*jujucloud.Cloud, error)
}
+type CloudCredential struct {
Added missing comment.
Changed tabular output when no credentials defined per bug # 1596687
Member

anastasiamac commented Sep 20, 2016

$$merge$$

Contributor

jujubot commented Sep 20, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

Contributor

jujubot commented Sep 20, 2016

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/9273

Member

anastasiamac commented Sep 20, 2016

intermittent bug # 1623178 TxnPrunerSuite.TestPrunes
$$merge$$

Contributor

jujubot commented Sep 20, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit 3bfb613 into juju:master Sep 20, 2016

@anastasiamac anastasiamac deleted the anastasiamac:list-credentials-lp1552274 branch Sep 20, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment