Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Synchronise between worker and test. #6290
Conversation
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
merged commit 56443f8
into
juju:master
Sep 20, 2016
howbazaar
deleted the
howbazaar:fix-txn-pruner-some-more
branch
Sep 20, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
howbazaar commentedSep 20, 2016
•
Edited 1 time
-
howbazaar
Sep 20, 2016
After adding more logging and running under the race detector, I was finally able to determine what was going on.
The test was looping around as soon as the worker signalled that the transactions were pruned, so the test clock was advanced another minute before the worker loop got around to call the next clock.After. Since we were waiting for a response every time we advanced the clock, it would fail because the worker already thought it was a minute after it should have been.
Fixes http://pad.lv/1623178
QA
Ran the test repeatedly with the race detector.