Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Stop the serving info setter replacing the cert from the cert updater. #6303
+42
−5
Conversation
| + if hasInfo { | ||
| + // Use the existing Cert as it may have been updated already | ||
| + // by the cert updater worker to have this machine's IP address | ||
| + // as part of the info. This changed cert is never put back into |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
merged commit 11f726a
into
juju:master
Sep 22, 2016
howbazaar
deleted the
howbazaar:cert-updater-test-fix
branch
Sep 22, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
howbazaar commentedSep 22, 2016
There was a race between the serving info setter and the cert updater.
Most of the time the serving info would run first, and set the cert based on the copy in the database. But sometimes the cert updater would run first and the new cert would be overwritten by the cert stored in the database.
QA
Was able to reproduce the failure by running the test repeatedly while the machine was very busy.
Can no longer reproduce the failure.