/juju

apiserver: Remove charm get cache #6309

Merged
merged 2 commits into from Sep 23, 2016

Conversation

Reviewers

@axw axw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@mjs @jujubot @axw
@mjs
Contributor

mjs commented Sep 23, 2016

(this is a backport from 2.0 - see also: #6302)

The filesystem cache used when retrieving charms has been removed. It was implemented when charms lived in a remote S3 bucket and is no longer necessary now that charm live in MongoDB's GridFS store. This helps to reduce disk space usage in the controllers and is one less thing that needs cleaning up when models are removed.

An upgrade step was also added. Now that the apiserver's charm get cache is no longer used it is removed to free up disk space.

This is part of the fix for https://bugs.launchpad.net/juju/+bug/1626304

mjs added some commits Sep 21, 2016

@mjs
apiserver: Remove charm get cache 
The filesystem cache used when retrieving charms has been removed. It
was implemented when charms lived in a remote S3 bucket and is no longer
necessary now that charm live in MongoDB's GridFS store. This helps to
reduce disk space usage in the controllers and is one less thing that
needs cleaning up when models are removed.

See:
- https://bugs.launchpad.net/juju/+bug/1608959
- https://bugs.launchpad.net/juju/+bug/1626304
7cf2391
@mjs
upgrades: Remove old apiserver charm get cache 
Now that the apiserver's charm get cache is no longer used, remove it
during upgrades to free up disk space.
a71f44f
@axw

axw approved these changes Sep 23, 2016
View changes

LGTM

@mjs
Contributor

mjs commented Sep 23, 2016

$$merge$$
@jujubot
Contributor

jujubot commented Sep 23, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju
@jujubot
Contributor

jujubot commented Sep 23, 2016

Build failed: Does not match ['fixes-1544796']
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/9315
@mjs
Contributor

mjs commented Sep 23, 2016

$$merge$$
@jujubot
Contributor

jujubot commented Sep 23, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju
@jujubot
Contributor

jujubot commented Sep 23, 2016

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/9317
@mjs
Contributor

mjs commented Sep 23, 2016

$$merge$$
@jujubot
Contributor

jujubot commented Sep 23, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit db061a3 into juju:1.25 Sep 23, 2016

@mjs mjs deleted the mjs:1626304-remove-charm-get-cache-1.25 branch Sep 23, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment