/juju

provider/azure: use simplestreams for images #6326

Closed
wants to merge 1 commit into
from

Conversation

Reviewers

@mjs mjs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@axw @mjs
@axw
Member

axw commented Sep 27, 2016

Update the Azure provider to use simplestreams
for identifying images. This requires changes
to both the image and agent simplestreams, as
we will now use the current endpoint values.

NOTE: this must not land until the simplestreams
changes have been made. If this lands first, then
the provider will be unusable.
@axw
Member

axw commented Sep 27, 2016

QA

  1. bootstrap with custom simplestreams using --metadata-source, with the current region/endpoint values, and IDs in the Azure image URN format (publisher:offer:sku:version).
  2. upload win2012 agent using github.com/axw/juju-tools
  3. add-machine --series=win2012
@mjs

mjs approved these changes Sep 27, 2016
View changes

Looks great as far as I understand it. Might be worth someone else also having a look.

provider/azure/environ.go
@@ -1412,12 +1412,10 @@ func (env *azureEnviron) getStorageAccountKeyLocked(accountName string, refresh
// TODO(axw) 2016-04-11 #1568715
// When we have image simplestreams, we should rename this to "Region",
// to implement simplestreams.HasRegion.
@mjs

mjs Sep 27, 2016

Contributor

Remove this TODO now?

provider/azure/internal/imageutils/images.go
@@ -1,218 +0,0 @@
-// Copyright 2015 Canonical Ltd.
@mjs

mjs Sep 27, 2016

Contributor

Niiiice :)

@axw axw changed the base branch from master to develop Dec 9, 2016

@axw
provider/azure: use simplestreams for images 
Update the Azure provider to use simplestreams
for identifying images. This requires changes
to both the image and agent simplestreams, as
we will now use the current endpoint values.
81dd8e4
@mjs
Contributor

mjs commented Apr 6, 2017

This is still waiting for simplestreams updates

@axw axw closed this May 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment