/juju

Migrate state tests from time.Now() to ZeroTime() #6328

Merged
merged 1 commit into from Sep 27, 2016

Conversation

Reviewers

@dimitern dimitern

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@macgreagoir @jujubot @dimitern
@macgreagoir
Contributor

macgreagoir commented Sep 27, 2016

Introduces, to state tests, the use of ZeroTime() from the testing
package, to replace time.Now() in cases where the the actual current
time is not required.

QA steps:

  • state tests should still pass
@macgreagoir
Migrate state tests from time.Now() to ZeroTime() 
Introduces, to state tests, the use of ZeroTime() from the testing
package, to replace time.Now() in cases where the the actual current
time is not required.
71f7fe1
@dimitern

dimitern approved these changes Sep 27, 2016
View changes

Perfect, thank you! LGTM

@macgreagoir
Contributor

macgreagoir commented Sep 27, 2016

$$merge$$
@jujubot
Contributor

jujubot commented Sep 27, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit 9e10488 into juju:master Sep 27, 2016
1 check passed

1 check passed

github-check-merge-juju Built PR, ran unit tests, and tested LXD deploy.
Details

@macgreagoir macgreagoir deleted the macgreagoir:state-zerotime branch Oct 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment