/juju

fixes to make tests pass under Go tip #6339

Merged
merged 1 commit into from Sep 28, 2016

Conversation

Reviewers

@mhilton mhilton

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@rogpeppe @jujubot @mhilton
@rogpeppe
Owner

rogpeppe commented Sep 28, 2016

The error message from strconv.Atoi has changed and the old certificates in the tests
are no longer considered valid and fail with a "x509: RSA key missing NULL parameters" error
when parsing.
@rogpeppe
fixes to make tests pass under Go tip 
The old certificates in the tests are no longer considered valid and
fail with a "x509: RSA key missing NULL parameters" error
when parsing.
23d54d3
@mhilton

mhilton approved these changes Sep 28, 2016
View changes

👍

@rogpeppe
Owner

rogpeppe commented Sep 28, 2016

[17:03:06] rogpeppe: I did, sorry I lgtmd in irc and forget to do it in gh

So I'm treating that as LGTM :)
@rogpeppe
Owner

rogpeppe commented Sep 28, 2016

$$merge$$
@jujubot
Contributor

jujubot commented Sep 28, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit bc3c45f into juju:master Sep 28, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment