/juju

stop prompting for domain name for rackspace credentials #6346

Merged
merged 1 commit into from Sep 28, 2016

Conversation

Reviewers

@kat-co kat-co

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@natefinch @jujubot @kat-co
@natefinch
Contributor

natefinch commented Sep 28, 2016

This fixes https://bugs.launchpad.net/juju/+bug/1624831

Rackspace uses openstack's v2 API, and thus doesn't use
the domain name. Additionally, if you do give a domain
name, juju gets confused and can't connect to rackspace
with a confusing error. This PR fixes the UX problem
of interactive add-credential prompting for domain-name.
@natefinch
stop prompting for domain name for rackspace credentials
This commit was signed with a verified signature.
@natefinch natefinch Nate Finch
GPG key ID: F5F09E8A6BAA1CCA Learn about signing commits
2881ee5
@kat-co

kat-co reviewed Sep 28, 2016
View changes

LGTM, but need QA steps.

@natefinch
Contributor

natefinch commented Sep 28, 2016

QA Steps:
juju add-credential rackspace
give some text to each prompt, it doesn't matter
Note that it never prompts for domain name
@natefinch
Contributor

natefinch commented Sep 28, 2016

$$merge$$
@jujubot
Contributor

jujubot commented Sep 28, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit 585e38c into juju:master Sep 28, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment