Add a new update-credential command #6373

Merged
merged 2 commits into from Oct 5, 2016

Conversation

Projects
None yet
3 participants
Owner

wallyworld commented Oct 4, 2016

Fixes: https://bugs.launchpad.net/juju/+bug/1623811

A new update-credential command is added. This allows locally updated credentials to be uploaded to the controller to replace any existing credentials which may be in use.

One major thing, otherwise looks fine.

cmd/juju/cloud/updatecredential.go
+ return nil
+}
+
+func (c *updateCredentialCommand) processError(client credentialAPI, initialErr error) error {
@axw

axw Oct 5, 2016

Member

-1, this assumes to much. Please either use a special error code or do the check in the client first.

@wallyworld

wallyworld Oct 5, 2016

Owner

I've moved the check to the backend.

axw approved these changes Oct 5, 2016

LGTM, please add QA steps.

Owner

wallyworld commented Oct 5, 2016

QA: bootstrap aws, change credential locally, run update-credential. verify also that attempt to update credential on lxd for aws is rejected.

Owner

wallyworld commented Oct 5, 2016

$$merge$$

Contributor

jujubot commented Oct 5, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit 4f6ae67 into juju:master Oct 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment