Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
api: Fix clock waits in TestLaterPingFails #6420
Conversation
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Tests failed |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
merged commit af4424b
into
juju:master
Oct 10, 2016
mjs
deleted the
mjs:1632105-TestLaterPingFails-fix
branch
Oct 10, 2016
| assertEvent(c, s.clock.Alarms()) | ||
| +} | ||
| + | ||
| +func (s *MonitorSuite) waitThenAdvance(c *gc.C, d time.Duration) { |
reedobrien
Oct 11, 2016
Contributor
FWIW I think this is the exact situation we added clock.WaitAdvance https://github.com/juju/testing/blob/master/clock.go#L112 for. With the added benefit that you can specify the number of timers to wait for, and it only waits if clock.waiting doesn't have than number of timers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
mjs commentedOct 10, 2016
•
Edited 1 time
-
mjs
Oct 10, 2016
This test was passing more by luck than anything.
Fixes https://bugs.launchpad.net/juju/+bug/1632105
QA
Many iterations with the stress test script. Before the fix the stress tester would trigger the problem within a handful of iterations.