Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Table headers are now FirstLetter case #6423
Conversation
| @@ -79,7 +79,7 @@ func (s *MachineListCommandSuite) TestMachine(c *gc.C) { | ||
| context, err := testing.RunCommand(c, newMachineListCommand()) | ||
| c.Assert(err, jc.ErrorIsNil) | ||
| c.Assert(testing.Stdout(context), gc.Equals, ""+ | ||
| - "MACHINE STATE DNS INS-ID SERIES AZ\n"+ | ||
| + "Machine State DNS Inst Id Series AZ\n"+ |
anastasiamac
Oct 11, 2016
Member
This should be either "Inst ID" as with "Model UUID" columns or "Inst id" as with "Last connection"
wallyworld
Oct 11, 2016
Owner
Fair point, I thought Id looked better. I've changed to id. We can also tweak later.
| @@ -240,7 +240,7 @@ func getModelMessage(model modelStatus) string { | ||
| func printMachines(tw *ansiterm.TabWriter, machines map[string]machineStatus) { | ||
| w := output.Wrapper{tw} | ||
| - w.Println("MACHINE", "STATE", "DNS", "INS-ID", "SERIES", "AZ") | ||
| + w.Println("Machine", "State", "DNS", "Inst Id", "Series", "AZ") |
| @@ -88,7 +88,7 @@ func (s *ListSuite) TestFilesystemListWithErrorResults(c *gc.C) { | ||
| } | ||
| var expectedFilesystemListTabular = ` | ||
| -MACHINE UNIT STORAGE ID VOLUME PROVIDER-ID MOUNTPOINT SIZE STATE MESSAGE | ||
| +Machine Unit Storage Id Volume Provider Id Mountpoint Size State Message |
| @@ -27,7 +27,7 @@ func formatMetadataTabular(writer io.Writer, metadata []MetadataInfo) { | ||
| print := func(values ...string) { | ||
| fmt.Fprintln(tw, strings.Join(values, "\t")) | ||
| } | ||
| - print("SOURCE", "SERIES", "ARCH", "REGION", "IMAGE-ID", "STREAM", "VIRT-TYPE", "STORAGE-TYPE") | ||
| + print("Source", "Series", "Arch", "Region", "Image Id", "Stream", "Virt Type", "Storage Type") |
| @@ -252,14 +252,14 @@ func (s *SvcTabularSuite) TestFormatSvcTabularMulti(c *gc.C) { | ||
| // Notes: sorted by name, then by revision, newest first. | ||
| c.Check(data, gc.Equals, ` | ||
| [Service] | ||
| -RESOURCE SUPPLIED BY REVISION | ||
| +Resource Supplied By Revision |
anastasiamac
Oct 11, 2016
Member
Why is "by" capitalised but "connection" in "Last connection" isn't?
| @@ -75,7 +75,7 @@ func (s *outputTabularSuite) TestFormatTabularMulti(c *gc.C) { | ||
| c.Check(buff.String(), gc.Equals, ` | ||
| [Unit Payloads] | ||
| -UNIT MACHINE PAYLOAD-CLASS STATUS TYPE ID TAGS | ||
| +Unit Machine Payload Class Status Type Id Tags |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
merged commit 0e43361
into
juju:master
Oct 11, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
wallyworld commentedOct 11, 2016
All tables headers are now FirstLetter case. Except for things like "Model UUID" because UUID is generally capitalised.
QA - bootstrap and run various list related commands.